-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce Link to OSM water well editor #873
Comments
Hi @tordans The link broke some time ago. Don't know when, might be related to your infra refactor? |
@ff6347 that is wonderful to hear. Feel free to ping me any time those things break! The new theme works and can be updated more easily should it break. The URL template string should be something like |
Hi @tordans I'm currently working on bringing the pump link back. I tried out the link for a specific pump: which removed the node id while redirecting to (Tried out in incognito mode) Can you provide a working link which leads directly to a pump? e.g. pump id = Thanks! |
Sorry, I thought I did. We had this issue in the last code as well which is why the lat/lng/zoom was added in the last code. But I hope there is a cleaner solution and I asked in the MapComplete Matrix channel about it. The Link that would work right away is |
We added a link to a MapComplete Water Well Editor in #460 and I am surprised to see that it was removed.
Source
To be honest, I am even more surprised that it was removed without any ping to me / the Berlin OSM Community about it. We have been promoting the app as a great example of collaborative data editing with OSM… which apparently it not true anymore.
With the start of the new season of public water well checking I updated the MapComplete theme this week to get it working with the latest MapComplete version. It is now hosted on MapComplete infrastructure at https://mapcomplete.org/theme.html?lat=52.47271334046087&lon=13.445970188175806&userlayout=https%3A%2F%2Fstudio.mapcomplete.org%2F11881%2Fthemes%2Fberlin_emergency_water_pumps%2Fberlin_emergency_water_pumps.json
Are you open to adding the link back to the dialogue?
Is that something you can add or would you prefer a PR from us?
The text was updated successfully, but these errors were encountered: