New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't warn about version ranges when the range is "[a,a]" #2251
Comments
If pedantic only were there to ensure repeatability, I'd agree. However, it's also there to help out in case you don't understand why your version isn't picked up. In this case, I'd like to get this warning if I try to override the version of If it's possible to detect whether a pinned ( |
Any Leiningen project which uses |
I can see why the warning cannot just be removed in this case, but I still think something needs to be done. For example, if you add
I don't think such a huge amount of output from a single dependency is useful, and it makes it very easy to miss any other problems. Also, I'm not sure the recommendation in the warning ( |
I am running into this with @emlyn If I leave the exclusions in, then explicitly add the excluded dependencies, I think many of the explicit dependencies would also need their own exclusion list. If the entire v2 AWS SDK were to move in this direction, this would be painful for anyone using AWS. I'm trying to understand the root problem. If I look at the pom [1] for dynamodb, I see the parent is
Looking at the maven docs for pom [3], the [1] https://search.maven.org/remotecontent?filepath=software/amazon/awssdk/dynamodb/2.0.6/dynamodb-2.0.6.pom |
Did anyone manage to work-around this issue? In one of my projects I've upgraded from AWS Java SDK V1 to V2 which means I get about 80 warning lines whenever I try to do My Dependencies
Warning messages
|
This should not be considered a solution or work-around, however the following in project.clj appears to silence the warnings:
I have not performed a review of the leiningen code to understand if this has other unintended side-effects. Use at your own risk. |
@hypirion If my understanding of your assessment is correct, removing warnings on ranges still allows for this to be picked up. With it, if I create a
I get warned that my pinning of |
In #734, lein added warning on dependency version ranges. This makes sense in the general case. However I noticed when running https://github.com/capitalone/cqrs-manager-for-distributed-reactive-services, that I got the following warning:
If you look at the pom for grpc-netty, you can see:
I'm guessing, but suspect that this is is a pseudo version range, to stop Maven from selecting anything else. This is to aid in reproducibility. Leiningen sees this as
[4.1.3.Final,4.1.3.Final]
and warns on the version range.Does it make sense to disable the warning in this specific case where the range specifier is the same on both ends?
The code to change is probably: https://github.com/xeqi/pedantic/blob/v0.2.0/src/pedantic/path.clj#L20-L24.
The text was updated successfully, but these errors were encountered: