Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI API calls to 2.0 #52

Merged
merged 1 commit into from Dec 6, 2019
Merged

Update CLI API calls to 2.0 #52

merged 1 commit into from Dec 6, 2019

Conversation

tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 6, 2019

Fixes #51

@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 6, 2019

@technosophos please merge this ASAP, as our docker build is broken until this is fixed.

Thanks!

@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 6, 2019

@christopherfujino FYI

@tvolkert tvolkert mentioned this pull request Dec 6, 2019
Closed
@technosophos
Copy link
Owner

Are you using Glide to build this or another build tool?

@technosophos technosophos merged commit 95331ce into technosophos:master Dec 6, 2019
@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 6, 2019

I'm a Go noob, so I flubbed my way through it 😄

I looked at the migration guide for CLI 2.0, and I pushed updates to my fork and ran go get -u github.com/tvolkert/dashing to test the fixes.

@tvolkert tvolkert deleted the cli branch December 6, 2019 18:42
@tvolkert
Copy link
Contributor Author

tvolkert commented Dec 6, 2019

Thanks!!

@coilysiren coilysiren mentioned this pull request Dec 6, 2019
Closed
@amake amake mentioned this pull request Dec 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go errors trying to build dashing
2 participants
@tvolkert @technosophos