Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Feature request: Stricter success reporting #97

Closed
relsqui opened this issue May 16, 2022 · 2 comments · Fixed by #89
Closed

Feature request: Stricter success reporting #97

relsqui opened this issue May 16, 2022 · 2 comments · Fixed by #89
Assignees
Labels
Type: Feature New feature or request
Projects

Comments

@relsqui
Copy link

relsqui commented May 16, 2022

Please describe your suggestion: 提案の概要

I'm using this action to trigger a notification when a deployment workflow fails. In this workflow, a job being skipped always means something went wrong and we should be notified, but this action reports a successful conclusion even when jobs are skipped.

Describe the solution you'd like: 考えうる解決方法

Only report the conclusion as success if all jobs were actually successful.

For backwards compatibility, this behavior could be behind a boolean input variable like strict_success and default to false.

Describe alternatives you've considered: 考えうる代替案

Outputting the list of results for all jobs would also serve my purposes, but I see you already turned down that suggestion in #53. The workaround in your comment there doesn't work for me, because this notification is a reusable job we call from different workflows -- to get each job result myself, I would have to reimplement most of workflow-conclusion-action (which is why I'm requesting it here instead).

Additional context: 補足

If you're open to this feature but don't have time for it, I can try making a PR for it.

@welcome
Copy link

welcome bot commented May 16, 2022

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@github-actions github-actions bot added this to To do in Backlog May 16, 2022
@technote-space technote-space moved this from To do to In progress in Backlog Jun 1, 2022
@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Jun 1, 2022
@technote-space technote-space added the Type: Feature New feature or request label Jun 1, 2022
technote-space added a commit that referenced this issue Jun 2, 2022
@github-actions github-actions bot mentioned this issue Jun 2, 2022
1 task
Backlog automation moved this from In progress to Done Jun 3, 2022
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Jun 3, 2022
@relsqui
Copy link
Author

relsqui commented Jun 3, 2022

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New feature or request
Projects
Backlog
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants