Prevent issues with stacks exactly 11 deep #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was seeing `panic serving 10.40.243.118:44663: runtime error: index out of range` `/tmp/build_c0c3d66e-c25b-42a1-9bf2-a77b92b2f44c/.vendor/src/github.com/github/go-opstocat/haystack.go:36 +0x65a` when attempting to report an exception via grohl + go-opstocat. [haystack.go:36](https://github.com/github/go-opstocat/blob/7faea155fd76d1c43f9dd30622664674586cbbc1/haystack.go#L36) attempts to grab the first frame in the backtrace, but apparently the slice was empty! I found this bit of code which, as it was previously written, returns an empty slice if the stack is exactly 11 frames deep. I think the intention was to always grab the top 10 stack frames; if so, I think it can be rewritten like this. Reminder that go's slice range indices are exclusive: `[0:10]` means grab elements 0 through 9.
| return all | ||
| } else { | ||
| return all[10 : len(all)-1] | ||
| return all[0:10] |
There was a problem hiding this comment.
The old code starts at index 10 and went to the end. I don't remember why it needed to skip the first 10 lines though.
There was a problem hiding this comment.
Should we just preserve the entire backtrace?
There was a problem hiding this comment.
I think it had to do with the first 10 lines being the same in every trace, or something. But yeah maybe preserving all of them is the best thing to do.
There was a problem hiding this comment.
I'm kinda leaning toward that the more I think about it. If I change it to just return all, is that 👍 with you?
|
OK, ready for some 👀 |
|
Had a minor test failure. Also cleaned stuff a bit more. Removing the need to count to 11 simplifies things a bit :) |
technoweenie
added a commit
that referenced
this pull request
Aug 7, 2014
Prevent issues with stacks exactly 11 deep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing
panic serving 10.40.243.118:44663: runtime error: index out of range/tmp/build_c0c3d66e-c25b-42a1-9bf2-a77b92b2f44c/.vendor/src/github.com/github/go-opstocat/haystack.go:36+0x65awhen attempting to report an exception via grohl + go-opstocat.haystack.go:36 attempts to grab the first frame in the backtrace, but apparently the slice was empty!
I found this bit of code which, as it was previously written, returns an empty slice if the stack is exactly 11 frames deep.
I think the intention was to always grab the top 10 stack frames; if so, I think it can be rewritten like this. Reminder that go's slice range indices are exclusive:
[0:10]means grab elements 0 through 9./cc: @technoweenie