You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In reality, the callback will receive its arguments in the reverse order. Here is the relevant code (line 49 of the compiled index.js):
this.emit('finished',job.name,err);
So either the readme or the code has to change. Personally, I think the code should be changed to reflect the README, even though this might break some applications. Sending the error first is a very strong convention.
The text was updated successfully, but these errors were encountered:
…node libs
As pointed out in #8, the read me and the code didn't agree with the
position
of the "finished" callback arguments. I hate to make such a weird
breaking
change, but the library should act like other node libs as it hits 1.0.
Your readme example contains the following code:
In reality, the callback will receive its arguments in the reverse order. Here is the relevant code (line 49 of the compiled index.js):
So either the readme or the code has to change. Personally, I think the code should be changed to reflect the README, even though this might break some applications. Sending the error first is a very strong convention.
The text was updated successfully, but these errors were encountered: