Changing any network setting resets HA device/entity customization

[mundschenk-at]

Changing anything in the /mqttconfig screen results in all device/entity customizations (friendly name, icon, entity slug) being reset because the HA discovery data is removed even when the HA topic was not changed at all. This is because all config keys are always present when saving (also ensuring a restart on every save because configChanged is always true).

[rodriguezst]

My fault, sorry. Entities are removed from HASS when a value is set as topic (to avoid orphan MQTT retained messages) but even when the topic is not changed and only other MQTT options are changed that function is triggered with a value equal to the previous one.
A check to see if value is equal to the one stored at preference_mqtt_hass_discovery shall be added here:

nuki_hub/WebCfgServer.cpp

Line 237 in afe2a81

// Previous HASS config has to be disabled first (remove retained MQTT messages)

I cannot do it myself right now. I am on vacation with limited access to test changes :(

[technyon]

I have added the suggested fix (not committed yet). Can you check if it works like this?

nuki_hub.zip

[mundschenk-at]

I updated the FW and clicked "Save" without actually changing any setting - the HA entities stayed safely in their customized form.

[technyon]

ok I'll prepare a release then