Add Ring as an event in Home Assistant + typo fix in mattDeviceName #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add ring as an event in Home Assistant, which would be the preferred way to expose stateless entities. Altough the binary_sensor for ring will be redundant, I elected not to delete it to not interfere with anyone using the current sensor in automations for example.
-Split Home Assistant path concat and DynamicJsonObject creation to functions seperate from publishHassTopic to allow more complex additionalEntries (such as nestedArrays, needed for events to pass event types) with as little duplicate code as possible.
-Fix a typo in
mattDeviceName->mqttDeviceName