Disable UpdateAuthData when no PIN is set #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the API (and as evident from using the Nuki App) the Nuki PIN is required to retrieve auth data from the lock.
There currently is no check in NukiWrapper::updateAuthData() or NukiOpenerWrapper::updateAuthData() to check if the security PIN is set.
Enabling Publish Auth Data without a PIN set will result in lockouts of not just Nuki Hub but all systems using the API because Nuki Hub tries to retrieve the auth data with a PIN of 0.
PR fixes this behaviour.