Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DTS to follow the PlatformIO standard structure #343

Merged
merged 3 commits into from
May 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ build
cmake-build-debug
cmake-build-release
cmake-build-release-s3
.pio
.vscode
.project
58 changes: 29 additions & 29 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,34 +42,34 @@ include_directories(${PROJECT_NAME}
)

set(SRCFILES
Config.h
NukiDeviceId.cpp
CharBuffer.cpp
Network.cpp
MqttReceiver.h
NetworkLock.cpp
NetworkOpener.cpp
networkDevices/NetworkDevice.h
networkDevices/NetworkDevice.cpp
networkDevices/WifiDevice.cpp
networkDevices/W5500Device.cpp
networkDevices/EthLan8720Device.cpp
networkDevices/ClientSyncW5500.cpp
networkDevices/espMqttClientW5500.cpp
networkDevices/IPConfiguration.cpp
LockActionResult.h
QueryCommand.h
NukiWrapper.cpp
NukiOpenerWrapper.cpp
MqttTopics.h
Ota.cpp
WebCfgServerConstants.h
WebCfgServer.cpp
PresenceDetection.cpp
PreferencesKeys.h
Gpio.cpp
Logger.cpp
RestartReason.h
src/Config.h
src/NukiDeviceId.cpp
src/CharBuffer.cpp
src/Network.cpp
src/MqttReceiver.h
src/NetworkLock.cpp
src/NetworkOpener.cpp
src/networkDevices/NetworkDevice.h
src/networkDevices/NetworkDevice.cpp
src/networkDevices/WifiDevice.cpp
src/networkDevices/W5500Device.cpp
src/networkDevices/EthLan8720Device.cpp
src/networkDevices/ClientSyncW5500.cpp
src/networkDevices/espMqttClientW5500.cpp
src/networkDevices/IPConfiguration.cpp
src/LockActionResult.h
src/QueryCommand.h
src/NukiWrapper.cpp
src/NukiOpenerWrapper.cpp
src/MqttTopics.h
src/Ota.cpp
src/WebCfgServerConstants.h
src/WebCfgServer.cpp
src/PresenceDetection.cpp
src/PreferencesKeys.h
src/Gpio.cpp
src/Logger.cpp
src/RestartReason.h
# include/RTOS.h
lib/WiFiManager/WiFiManager.cpp
lib/WiFiManager/wm_consts_en.h
Expand Down Expand Up @@ -114,7 +114,7 @@ file(GLOB_RECURSE SRCFILESREC
)

add_executable(${PROJECT_NAME}
main.cpp
src/main.cpp
${SRCFILES}
${SRCFILESREC}
)
Expand Down
8 changes: 2 additions & 6 deletions Docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,10 @@ RUN cd ~/arduino* && \

RUN git clone --recurse-submodules https://github.com/technyon/Arduino-CMake-Toolchain.git ~/Arduino-CMake-Toolchain

COPY icon /usr/src/nuki_hub/icon
COPY include /usr/src/nuki_hub/include
COPY src /usr/src/nuki_hub/src
COPY lib /usr/src/nuki_hub/lib
COPY networkDevices /usr/src/nuki_hub/networkDevices
COPY include /usr/src/nuki_hub/include
COPY CMakeLists.txt /usr/src/nuki_hub
COPY index.html /usr/src/nuki_hub
COPY *.h /usr/src/nuki_hub/
COPY *.cpp /usr/src/nuki_hub/

RUN mkdir -p /usr/src/nuki_hub/build

Expand Down
39 changes: 39 additions & 0 deletions include/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@

This directory is intended for project header files.

A header file is a file containing C declarations and macro definitions
to be shared between several project source files. You request the use of a
header file in your project source file (C, C++, etc) located in `src` folder
by including it, with the C preprocessing directive `#include'.

```src/main.c

#include "header.h"

int main (void)
{
...
}
```

Including a header file produces the same results as copying the header file
into each source file that needs it. Such copying would be time-consuming
and error-prone. With a header file, the related declarations appear
in only one place. If they need to be changed, they can be changed in one
place, and programs that include the header file will automatically use the
new version when next recompiled. The header file eliminates the labor of
finding and changing all the copies as well as the risk that a failure to
find one copy will result in inconsistencies within a program.

In C, the usual convention is to give header files names that end with `.h'.
It is most portable to use only letters, digits, dashes, and underscores in
header file names, and at most one dot.

Read more about using header files in official GCC documentation:

* Include Syntax
* Include Operation
* Once-Only Headers
* Computed Includes

https://gcc.gnu.org/onlinedocs/cpp/Header-Files.html
46 changes: 46 additions & 0 deletions lib/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@

This directory is intended for project specific (private) libraries.
PlatformIO will compile them to static libraries and link into executable file.

The source code of each library should be placed in an own separate directory
("lib/your_library_name/[here are source files]").

For example, see a structure of the following two libraries `Foo` and `Bar`:

|--lib
| |
| |--Bar
| | |--docs
| | |--examples
| | |--src
| | |- Bar.c
| | |- Bar.h
| | |- library.json (optional, custom build options, etc) https://docs.platformio.org/page/librarymanager/config.html
| |
| |--Foo
| | |- Foo.c
| | |- Foo.h
| |
| |- README --> THIS FILE
|
|- platformio.ini
|--src
|- main.c

and a contents of `src/main.c`:
```
#include <Foo.h>
#include <Bar.h>

int main (void)
{
...
}

```

PlatformIO Library Dependency Finder will find automatically dependent
libraries scanning project source files.

More information about PlatformIO Library Dependency Finder
- https://docs.platformio.org/page/librarymanager/ldf.html
10 changes: 1 addition & 9 deletions platformio.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

[platformio]
default_envs = esp32dev
src_dir = .

[env]
platform = espressif32
Expand All @@ -34,18 +33,11 @@ build_flags =
; -DDEBUG_NUKI_HEX_DATA
; -DDEBUG_NUKI_READABLE_DATA
lib_deps =
https://github.com/technyon/nuki_ble.git
bertmelis/espMqttClient@1.6.0
bblanchon/ArduinoJson@7.0.4

monitor_speed = 115200
monitor_filters =
esp32_exception_decoder
time
build_src_filter =
-<*>
+<*.cpp>
+<*.h>
+<networkDevices>

[env:esp32dev]
board = esp32dev
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion Gpio.cpp → src/Gpio.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "Logger.h"
#include "PreferencesKeys.h"
#include "RestartReason.h"
#include "lib/gpio2go/src/Gpio2Go.h"
#include "../lib/gpio2go/src/Gpio2Go.h"

Gpio* Gpio::_inst = nullptr;
unsigned long Gpio::_debounceTs = 0;
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
11 changes: 11 additions & 0 deletions test/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

This directory is intended for PlatformIO Test Runner and project tests.

Unit Testing is a software testing method by which individual units of
source code, sets of one or more MCU program modules together with associated
control data, usage procedures, and operating procedures, are tested to
determine whether they are fit for use. Unit testing finds problems early
in the development cycle.

More information about PlatformIO Unit Testing:
- https://docs.platformio.org/en/latest/advanced/unit-testing/index.html