Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuthName and Authorization log, check for validPin #368

Merged
merged 1 commit into from
May 21, 2024

Conversation

iranl
Copy link
Collaborator

@iranl iranl commented May 19, 2024

  • Fix AuthName

Closes #366

  • Fix Authorization log: Nuki Hub was requesting/recieving the entire log in ascending order. Now only requests the 5 most recent log entries.

Closes #294
Closes #270

  • Small modifications to Platform IO debug builds to properly send debug data to serial

  • Check for valid PIN instead of just PIN set

@iranl iranl added this to the 8.35 milestone May 19, 2024
@iranl iranl self-assigned this May 19, 2024
@iranl iranl added the bug Something isn't working label May 19, 2024
@iranl iranl force-pushed the Fix-AuthName branch 9 times, most recently from 77ea5be to 63809b8 Compare May 19, 2024 20:22
@iranl iranl changed the title Fix AuthName Fix AuthName and Authorization log, check for validPin May 19, 2024
@iranl iranl marked this pull request as ready for review May 19, 2024 20:37
@iranl iranl added the enhancement New feature or request label May 19, 2024
@iranl iranl marked this pull request as draft May 20, 2024 05:27
@iranl iranl marked this pull request as ready for review May 20, 2024 18:44
@technyon technyon merged commit 10709fc into technyon:master May 21, 2024
2 checks passed
@iranl iranl deleted the Fix-AuthName branch May 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants