Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: main menu navigation rework #394

Merged
merged 6 commits into from
Jun 8, 2024
Merged

web: main menu navigation rework #394

merged 6 commits into from
Jun 8, 2024

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Jun 6, 2024 •
edited
Loading

Compare original mobile view - before and after (recorded with PC).
nukidemo.mp4

Changes

  • Create new function to draw navigation menu elements.
  • Changes <form> to <a href> links.
  • Add CSS animation

@iranl iranl added the enhancement New feature or request label Jun 6, 2024
@iranl iranl added this to the 8.35 milestone Jun 6, 2024
@iranl
Copy link
Collaborator

iranl commented Jun 6, 2024

Looks good

@iranl
Copy link
Collaborator

iranl commented Jun 7, 2024

Please resolve conflicts and mark as ready for review

@duhow duhow marked this pull request as ready for review June 7, 2024 14:30
@duhow
Copy link
Contributor Author

duhow commented Jun 7, 2024

All yours @iranl @technyon !

@technyon technyon merged commit a79ce78 into technyon:master Jun 8, 2024
9 checks passed
@duhow duhow deleted the index-web branch July 3, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iranl iranl iranl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
8.35
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duhow @iranl @technyon