Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator.totalPages does not count external documents #248

Closed
hajjD opened this issue Nov 13, 2020 · 2 comments · Fixed by #260
Closed

Generator.totalPages does not count external documents #248

hajjD opened this issue Nov 13, 2020 · 2 comments · Fixed by #260
Assignees
Labels

Comments

@hajjD
Copy link

hajjD commented Nov 13, 2020

What did you do?

Created a new pdf, added an external document with 150 pages. And generated the PDF

What did you expect to happen?

for generator.totalPages to accurately reflect the number of pages

What happened instead?

It claims there is only one page. This was working on an earlier version of tppdf

TPPDF Environment

TPPDF version: 2.31
Xcode version: 12.1
Swift version: 5.x

Demo Code / Project

ℹ Please add a code snippet, link to or upload a project we can download that reproduces the issue.
ℹ We need a fully compilingPDFDocument

@hajjD hajjD changed the title Generator.totalPages does not count external documentd Generator.totalPages does not count external documents Nov 13, 2020
@philprime philprime self-assigned this Jan 3, 2021
@philprime philprime added the bug label Jan 3, 2021
@philprime
Copy link
Member

Should be fixed in feature/247-fixing-empty-external-page. Please take a look and verify that the updated behavior is correct

philprime pushed a commit that referenced this issue Jan 6, 2021
@philprime
Copy link
Member

Fixed in branch develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants