Enhancement: Add possibility to draw a bordered PDFTable with corners radius #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2018 11:33
… radius. Solution: Add `radius` propriety on `PDFLineStyle` inside `PDFGraphics.createRectPath(rect:, outline:)` If the radius propriety of `outline` is not nil, we will used `UIBezierPath.init(roundedRect:, cornerRadius:)` corner radius parameter will be filled with `PDFLineStyle.radius`. Changes to be committed: modified: README.md modified: Source/Graphics/PDFGraphics.swift modified: Source/Graphics/PDFLineStyle.swift
Closed
|
Looks good! Thank you for your contribution! Going to to merge and release it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First, thank you for your work it's been a long time that I searching for a really good PDF creator and you did it! 👍
But now, I need to copy my old HTML generated pdf to your great solution but i've border radius on it and I saw you don't add this possibility when we draw rect like tables... So, I enhance a little bit
PDFGraphics.createRectPath=).Please find details below :
Solution:
Add
radiuspropriety onPDFLineStyle. InsidePDFGraphics.createRectPath(rect:, outline:)if the radius propriety ofoutlineis not nil, we will useUIBezierPath.init(roundedRect:, cornerRadius:)Corner radius parameter will be filled with
PDFLineStyle.radius.Changes to be committed:
modified: README.md
modified: Source/Graphics/PDFGraphics.swift
modified: Source/Graphics/PDFLineStyle.swift