Update Invoke-ScriptSentry.ps1 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tool on a domain without Mapped Drives nor GPO Logon Scripts, PowerShell hangs and then throws the exception `ParameterArgumentValidationErrorNullNotAllowed`. I wrapped the function calls that use `$GPOLogonScripts` and `$MappedDrives` with an if statement to check for null. This might be applicable for other variables.
|
Ah yes. I had known about this but hadn't had the time to throw some error handling in to accommodate this use case. I appreciate the PR. I'll review this and other areas where this same issue might arise. I appreciate it!! |
|
Most welcome. I did nothing. We mentioned and showcased your tool in an upcoming HTB Academy module called DACL Attacks II. Hope it will make it more well-known. |
|
Oh wow @PedantHTB that's super awesome! Is there any way you might be able to send me a screenshot or something showing it in the HTB Academy? For posterity. 😀Thank you! |
|
Sure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tool on a domain without Mapped Drives nor GPO Logon Scripts, PowerShell hangs and then throws the exception
ParameterArgumentValidationErrorNullNotAllowed.I wrapped the function calls that use
$GPOLogonScriptsand$MappedDriveswith an if statement to check for null. This might be applicable for other variables.