Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UnitTestRuntimeProvider into RuntimePlugins of Test Framework #1177

Closed
SabotageAndi opened this issue Jun 18, 2018 · 4 comments
Closed

Comments

@SabotageAndi
Copy link
Contributor

SabotageAndi commented Jun 18, 2018

See https://github.com/techtalk/SpecFlow/tree/DotNetCore/TechTalk.SpecFlow/UnitTestProvider

They can be easier implemented in the plugins for the unit test frameworks.

From #1176:
This has the additional benefit, that adaptions for different unit test provider are now easier to do.
We don't need anymore to do reflection stuff like https://github.com/techtalk/SpecFlow/blob/DotNetCore/TechTalk.SpecFlow/UnitTestProvider/NUnitRuntimeProvider.cs#L25 and can call the APIs direct.

@colinkcodes
Copy link

Hi, I'm new to open source contributing and I'd like to work on this issue if that's OK?

To help clarify the situation (as the links above no longer work):

  • everything in the TechTalk.SpecFlow/UnitTestProvider folder is to be relocated to a new folder with a path of TechTalk.SpecFlow/TestFramework/RuntimePlugins/UnitTestProvider
  • change the namespace of the moved items to reflect their new home
  • fix everything that the above changes break

or is there a more appropriate location now since this issue has been around for a while?

@SabotageAndi
Copy link
Contributor Author

@colinkcodes
Your action would be right. But we already did this and forgot to close this issue. Sorry for the confusion.

@colinkcodes
Copy link

No problem, anything to help.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
FH ITP3
  
Open
Development

No branches or pull requests

3 participants