Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new example with composer & fix CI #356

Merged
merged 5 commits into from Jul 10, 2021
Merged

Add a new example with composer & fix CI #356

merged 5 commits into from Jul 10, 2021

Conversation

williamdes
Copy link
Contributor

composer dump-autoload
php -f examples/example_066.php > example_066.pdf

And then view the PDF with your browser

@codecov-io
Copy link

codecov-io commented Apr 2, 2021

Codecov Report

Merging #356 (930b1d0) into main (cf8a66c) will decrease coverage by 7.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   72.80%   65.41%   -7.39%     
==========================================
  Files         125      117       -8     
  Lines       22959    21286    -1673     
==========================================
- Hits        16716    13925    -2791     
- Misses       6243     7361    +1118     
Flag Coverage Δ
php-5.3-ubuntu-latest ?
php-5.6-ubuntu-latest ?
php-7.1-ubuntu-latest 45.68% <ø> (+<0.01%) ⬆️
php-7.2-ubuntu-latest 45.63% <ø> (-0.01%) ⬇️
php-7.3-ubuntu-latest 45.62% <ø> (ø)
php-7.4-ubuntu-latest 45.63% <ø> (+<0.01%) ⬆️
php-8.0-ubuntu-latest 65.38% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/example_066.php 100.00% <100.00%> (ø)
examples/example_027.php 61.53% <0.00%> (-37.96%) ⬇️
examples/example_058.php 75.86% <0.00%> (-24.14%) ⬇️
tcpdf_barcodes_1d.php 69.36% <0.00%> (-21.08%) ⬇️
examples/example_039.php 80.64% <0.00%> (-19.36%) ⬇️
tcpdf_barcodes_2d.php 65.95% <0.00%> (-10.02%) ⬇️
include/tcpdf_fonts.php 36.51% <0.00%> (-8.26%) ⬇️
tcpdf.php 62.88% <0.00%> (-8.05%) ⬇️
include/tcpdf_static.php 48.07% <0.00%> (-5.47%) ⬇️
include/tcpdf_colors.php 36.28% <0.00%> (-0.39%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8a66c...930b1d0. Read the comment docs.

@@ -0,0 +1,86 @@
<?php

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolaasuni if you find this block style more clean I can make a PR for it
Already converted all the blocks on the fork, so cherry-pick and PR is possible

@williamdes
Copy link
Contributor Author

Hi @nicolaasuni
You are probably very busy, but could we talk about having more people with write access to this repository?

@williamdes williamdes changed the title Add a new example with composer Add a new example with composer & fix CI Jul 9, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #356 (3fcd050) into main (5bc5d01) will decrease coverage by 7.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   72.77%   65.39%   -7.38%     
==========================================
  Files         125      117       -8     
  Lines       22968    21293    -1675     
==========================================
- Hits        16715    13925    -2790     
- Misses       6253     7368    +1115     
Flag Coverage Δ
php-5.3-ubuntu-latest ?
php-5.6-ubuntu-latest ?
php-7.1-ubuntu-latest 45.67% <ø> (ø)
php-7.2-ubuntu-latest 45.61% <ø> (ø)
php-7.3-ubuntu-latest ?
php-7.4-ubuntu-latest ?
php-8.0-ubuntu-latest 65.35% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/example_066.php 100.00% <100.00%> (ø)
examples/example_027.php 61.53% <0.00%> (-37.96%) ⬇️
examples/example_058.php 75.86% <0.00%> (-24.14%) ⬇️
tcpdf_barcodes_1d.php 69.48% <0.00%> (-20.97%) ⬇️
examples/example_039.php 80.64% <0.00%> (-19.36%) ⬇️
tcpdf_barcodes_2d.php 65.95% <0.00%> (-10.02%) ⬇️
include/tcpdf_fonts.php 36.51% <0.00%> (-8.26%) ⬇️
tcpdf.php 62.84% <0.00%> (-8.04%) ⬇️
include/tcpdf_static.php 48.07% <0.00%> (-5.47%) ⬇️
include/tcpdf_colors.php 36.28% <0.00%> (-0.39%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc5d01...3fcd050. Read the comment docs.

@nicolaasuni nicolaasuni merged commit 150e756 into tecnickcom:main Jul 10, 2021
@williamdes williamdes deleted the composer-autoload-example branch July 10, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants