Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZTEC Code encoder #79

Merged
merged 67 commits into from
Oct 20, 2023
Merged

AZTEC Code encoder #79

merged 67 commits into from
Oct 20, 2023

Conversation

nicolaasuni
Copy link
Member

@nicolaasuni nicolaasuni commented Oct 20, 2023

Description

New AZTEC Code encoder (ISO/IEC 24778:2008).
Minimum PHP version has been raised to PHP 5.6 to support constant arrays.

Checklist:

  • The make buildall command has been run successfully without any error or warning.
  • Any new code line is covered by unit tests and the coverage has not dropped.
  • Any new code follows the style guidelines of this project.
  • The code changes have been self-reviewed.
  • Corresponding changes to the documentation have been made.
  • The version has been updated in the VERSION file.

Type of change:

  • New feature (non-breaking change which adds functionality) → The minor number in the VERSION file has been increased.

Copy link
Member Author

@nicolaasuni nicolaasuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b74f197) 97.73% compared to head (6d7cb18) 98.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #79      +/-   ##
============================================
+ Coverage     97.73%   98.14%   +0.41%     
- Complexity     1030     1214     +184     
============================================
  Files            59       65       +6     
  Lines          3845     3944      +99     
============================================
+ Hits           3758     3871     +113     
+ Misses           87       73      -14     
Flag Coverage Δ
php-5.5-ubuntu-latest ?
php-5.6-ubuntu-latest ?
php-7.1-ubuntu-latest ?
php-7.2-ubuntu-latest 98.13% <100.00%> (+0.38%) ⬆️
php-7.3-ubuntu-latest 98.11% <100.00%> (+0.37%) ⬆️
php-7.4-ubuntu-latest 98.11% <100.00%> (+0.37%) ⬆️
php-8.0-ubuntu-latest 98.11% <100.00%> (?)
php-8.1-ubuntu-latest 98.11% <100.00%> (+0.37%) ⬆️
php-8.2-ubuntu-latest 98.09% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Barcode.php 100.00% <100.00%> (ø)
src/Type/Linear/Imb.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec/Bitstream.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec/Codeword.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec/Encode.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec/ErrorCorrection.php 100.00% <100.00%> (ø)
src/Type/Square/Aztec/Layers.php 100.00% <100.00%> (ø)
src/Type/Square/Datamatrix.php 98.95% <ø> (+0.79%) ⬆️
src/Type/Square/Datamatrix/Data.php 80.00% <100.00%> (-3.34%) ⬇️
... and 15 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaasuni nicolaasuni mentioned this pull request Oct 20, 2023
@nicolaasuni nicolaasuni merged commit 8181d55 into main Oct 20, 2023
9 checks passed
@nicolaasuni nicolaasuni deleted the aztec branch October 20, 2023 23:32
@nicolaasuni nicolaasuni mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants