Adding a test when log is nil, also rendering an empty string instead…

… of nil
tecnobrat · Mar 27, 2012 · ff142d1 · ff142d1 · seanmarcia · Oct 29, 2013
1 parent b14ceea
commit ff142d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -76,7 +76,8 @@ def display_builder_state(state)
   end
 
   def format_changeset_log(log)
-    h(log.strip) if log.present?
+    log = "" if log.blank?
+    h(log.strip)
   end
 
   def elapsed_time(build, format = :general)

diff --git a/test/unit/application_helper_test.rb b/test/unit/application_helper_test.rb
@@ -35,6 +35,11 @@ class ApplicationHelperTest < ActionView::TestCase
   end
 
   context "#format_changeset_log" do
+    test "should render nothing if log is nil" do
+      @helper.extend(ERB::Util)
+      assert_equal "", @helper.format_changeset_log(nil)
+    end
+
     test "should strip html tags" do
       @helper.extend(ERB::Util)
       assert_equal "&lt;hr /&gt;some changeset&lt;script&gt;alert('bad')&lt;/script&gt;",