Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more faces #4

Closed
wants to merge 0 commits into from
Closed

Add more faces #4

wants to merge 0 commits into from

Conversation

elken
Copy link
Contributor

@elken elken commented May 30, 2022 •
edited

Add a couple more faces needed for HTML export in ox-chameleon

Marked as draft until copyright assignment is finalised

elken added a commit to elken/ox-chameleon that referenced this pull request May 30, 2022
@elken
feat: add html export
3e2b2b7 
Relies on some extra changes on engrave-faces[1], but these can be done
with a correctly set `engrave-faces-themes` for the most part.

[1] tecosaur/engrave-faces#4
@elken elken mentioned this pull request May 30, 2022
Merged
elken added a commit to elken/ox-chameleon that referenced this pull request May 30, 2022
@elken
feat: add html export
42f8251 
Relies on some extra changes on engrave-faces[1], but these can be done
with a correctly set `engrave-faces-themes` for the most part.

[1] tecosaur/engrave-faces#4
@elken elken marked this pull request as draft May 30, 2022 20:54
@elken elken marked this pull request as ready for review June 2, 2022 20:29
@elken
Copy link
Contributor Author

elken commented Jun 2, 2022

Copyright assignment resolved, if required teco I can send you my documents privately.

@tecosaur
Copy link
Owner

tecosaur commented Jun 4, 2022

Great!

tecosaur
tecosaur reviewed Jun 4, 2022
View reviewed changes
engrave-faces.el Outdated Show resolved Hide resolved
elken added a commit to elken/ox-chameleon that referenced this pull request Jun 4, 2022
@elken
feat: add html export
724d336 
Relies on some extra changes on engrave-faces[1], but these can be done
with a correctly set `engrave-faces-themes` for the most part.

[1] tecosaur/engrave-faces#4
@tecosaur
Copy link
Owner

tecosaur commented Jun 4, 2022

The outline slugs can't contain numbers, that's why I recommended oa (ob, oc, ...).
I'd also like the outline shorts to outline-N instead of o-N.
It would also be good if the alignment matched.

Lastly, I'm wondering if :family support should be added to LaTeX with this? Perhaps later.

@elken
Copy link
Contributor Author

elken commented Jun 4, 2022

The outline slugs can't contain numbers, that's why I recommended oa (ob, oc, ...). I'd also like the outline shorts to outline-N instead of o-N. It would also be good if the alignment matched.

Oh I misunderstood there, I get what you mean now.

Lastly, I'm wondering if :family support should be added to LaTeX with this? Perhaps later.

Absolutely, most of what I've added here should be in LaTeX if it's not already. There's still more that can be done here, eg better prettify/org-modern replacement and whatever other packages could apply styles.

@tecosaur tecosaur closed this Jun 4, 2022
@tecosaur
Copy link
Owner

tecosaur commented Jun 4, 2022

Why did me force pushing auto-close this?

@tecosaur
Copy link
Owner

tecosaur commented Jun 4, 2022

Oh, I pushed the wrong commit, and now I get permission denied when I re-push :(

@elken
Copy link
Contributor Author

elken commented Jun 4, 2022

uh oh

@tecosaur
Copy link
Owner

tecosaur commented Jun 4, 2022

Pushed in 94fbdb0

tecosaur pushed a commit to tecosaur/ox-chameleon that referenced this pull request Jun 28, 2022
@elken @tecosaur
feat: add html export
28c4354 
Relies on some extra changes on engrave-faces[1], but these can be done
with a correctly set `engrave-faces-themes` for the most part.

[1] tecosaur/engrave-faces#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecosaur tecosaur tecosaur left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elken @tecosaur