Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify target of build #1043

Merged
merged 5 commits into from
Jun 11, 2023

Conversation

xinslu
Copy link
Contributor

@xinslu xinslu commented May 25, 2023

Solves #970.

Simple PR that checks if an optional target is specified in the build command. If yes, matches it and builds only the specific output name.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1043 (93be224) into master (a3389b9) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 93be224 differs from pull request most recent head 1786aa3. Consider uploading reports for the commit 1786aa3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1043   +/-   ##
=======================================
  Coverage   45.09%   45.10%           
=======================================
  Files         155      155           
  Lines       62701    62705    +4     
=======================================
+ Hits        28278    28280    +2     
- Misses      34423    34425    +2     
Impacted Files Coverage Δ
src/bin/tectonic/v2cli.rs 43.20% <50.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xinslu
Copy link
Contributor Author

xinslu commented Jun 1, 2023

Hey, I don't mean to be pushy or anything like that. I just wanted to say that this PR is ready for review and let me know if I need to change anything. This is my first OSS contribution, so please excuse my stupidity if I did something wrong.

@pkgw
Copy link
Collaborator

pkgw commented Jun 5, 2023

@xinslu Sorry, this is all on my end — I've been overwhelmed with work responsibilities lately and am far behind on Tectonic reviews. This sounds like a change that I would like to accept so I aspire to look at it soon! And please feel free to ping me just in case I lose track of things. I try not to do that, but with so much going on it can easily happen.

pkgw added 3 commits June 11, 2023 10:56
This is slightly more efficient.

Also delete the comment, because the intent of the relevant code is
clear enough to not need explanation.
@pkgw
Copy link
Collaborator

pkgw commented Jun 11, 2023

I've made a few tweaks here — since I've been taking so long to look at this, I've gone ahead and pushed them to your branch so that I can go ahead and merge once the CI checks pass. Thanks for your contribution!

@pkgw pkgw merged commit f07baff into tectonic-typesetting:master Jun 11, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants