Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use c++ 17 #1202

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

winstxnhdw
Copy link

Closes #1190
Closes #1184
Closes #1178

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.93%. Comparing base (19654bf) to head (513caa0).

Files Patch % Lines
crates/engine_spx2html/src/fontfile.rs 0.00% 6 Missing ⚠️
crates/engine_spx2html/src/fonts.rs 0.00% 4 Missing ⚠️
crates/engine_spx2html/src/initialization.rs 0.00% 2 Missing ⚠️
crates/engine_spx2html/src/assets.rs 0.00% 1 Missing ⚠️
crates/xdv/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   46.99%   46.93%   -0.06%     
==========================================
  Files         176      177       +1     
  Lines       65196    65191       -5     
==========================================
- Hits        30639    30599      -40     
- Misses      34557    34592      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CraftSpider
Copy link
Contributor

Thank you for your work on this! I'll merge this once I find time to review it.

@winstxnhdw
Copy link
Author

FWIW, it is working fine on my project.

@CraftSpider
Copy link
Contributor

I'm not worried about the coverage failure personally - a decrease of .06 isn't really a big deal, and the clippy fixes I'm guessing just altered line hits slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails with icu 75 Tectonic 0.15.0 build fails Can build standalone but not as dependency
2 participants