-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use c++ 17 #1202
base: master
Are you sure you want to change the base?
fix: use c++ 17 #1202
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 46.99% 46.93% -0.06%
==========================================
Files 176 177 +1
Lines 65196 65191 -5
==========================================
- Hits 30639 30599 -40
- Misses 34557 34592 +35 ☔ View full report in Codecov by Sentry. |
Thank you for your work on this! I'll merge this once I find time to review it. |
FWIW, it is working fine on my project. |
I'm not worried about the coverage failure personally - a decrease of |
Closes #1190
Closes #1184
Closes #1178