Emit user-facing warning if unable to represent a character in the current font #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't *need* to copy the final NUL byte, but it will make this particular compiler happy and costs us essentially nothing.
Including at least one issue (the one in pdfencrypt.c) that looked like a genuine array bounds overflow bug.
…encountered I've recently gotten a few bug reports from people exploring Tectonic's Unicode capabilities that are not aware of the need to use the `fontspec` package and to choose an appropriate font. Here we add a Tectonic warning message that will hopefully point them in the right direction. In plain XeTeX, the warning is only printed if \tracelostchars is activated, but this seems like a big enough issue (and one that I don't think will happen spuriously?) that I think it is reasonable to always print a message. I can revisit if there are cases where the message gets annoying. I hope that the help message is actually helpful for non-experts. If not, perhaps we should create a dedicated forum thread and point people to it. Closes tectonic-typesetting#173.
|
This also includes some compiler warning fixes uncovered by my recent upgrade to GCC 8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further rationale in the commit messages. Attempting to address #173 in a helpful way.