A more robust parsing of the manifest #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split lines from the end into exactly three piecess and split only on
spaces (' ').
This allows filenames to have spaces in their names.
|
Nice! Yes, if we're trying to be thorough here, I guess we should also not try to record filenames that are invalid UTF-8, although I don't believe that TeX programs are able to construct such filenames. |
|
Thanks for having a look. Honestly, I have not been able to figure out how to construct a filename with a newline either to test the check. |
|
I think it might be possible with a If you can add a change that checks the result of |
|
OK, done. Thanks!
|
|
Thanks for the improvement! |
Mrmaxmeier
pushed a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #74 without actually changing the manifest format.
Now the lines in the manifest are split from the end (
rsplitn) into exactly three pieces and only onspaces (' ').
This allows filenames to have spaces in their names.
A sanity check has been added to not insert files with newline characters in their names. (I guess to prevent the potential to doctor a manifest line by crafting a file name).
Question: Is it worth inserting files with names that are not valid unicode, i.e. use
to_string_lossy? This record is then useless anyway because it will not match the original file.