Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP server: Add cache control #117

Closed
Tectu opened this issue Aug 18, 2022 · 1 comment
Closed

HTTP server: Add cache control #117

Tectu opened this issue Aug 18, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tectu
Copy link
Owner

Tectu commented Aug 18, 2022

Malloy is currently lacking the ability to set HTTP fields such as Cache-Control. This is especially important when serving assets such as via router::add_file_serving().
@Tectu Tectu added enhancement New feature or request good first issue Good for newcomers labels Aug 18, 2022
@Tectu
Copy link
Owner Author

Tectu commented Aug 18, 2022

Never mind... this was already implemented. There is an overload of router::add_file_serving() which additionally takes a callable for populating the Cache-Control field.

@Tectu Tectu closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tectu