Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH key based deploys #41

Closed
ryanto opened this issue Jan 23, 2015 · 1 comment
Closed

SSH key based deploys #41

ryanto opened this issue Jan 23, 2015 · 1 comment
Labels
cli engine

Comments

@ryanto
Copy link
Contributor

ryanto commented Jan 23, 2015

Use ssh key and not api key
@samselikoff samselikoff mentioned this issue Jan 23, 2015
Closed
10 tasks
ryanto added a commit that referenced this issue Jan 31, 2015
@ryanto
[#41] [Engine] Creating builds now requires SSH key
686f9a3 
No more API keys when creating builds. Each build must be signed by a
verifiable key.
ryanto added a commit that referenced this issue Feb 16, 2015
@ryanto
[#41] [Engine] Creating builds now requires SSH key
4a1d88a 
No more API keys when creating builds. Each build must be signed by a
verifiable key.
ryanto added a commit that referenced this issue Feb 17, 2015
@ryanto
[#41] [Engine] Creating builds now requires SSH key
7af45b5 
No more API keys when creating builds. Each build must be signed by a
verifiable key.
ryanto added a commit that referenced this issue Feb 17, 2015
@ryanto
[#41] Front end for SSH keys
28538fe 
* CRUD ssh keys that can deploy your apps.
ryanto added a commit that referenced this issue Feb 17, 2015
@ryanto
[#41] Remember which pubkey deployed the build
e393ac3
@ryanto
Copy link
Contributor Author

ryanto commented Feb 17, 2015

@samselikoff I think this is ready for review. This is pretty big...

It includes...

  1. A backend the verifies each post to create a new build is signed by one of the SSH keys (model: Pubkey).
  2. A front end for adding, listing, and deleting the various keys used by the system.

This is a pretty big change. There's still some more to do, but because this is so big I wouldnt mind reviewing these pieces now.

What's left (feel free to add).

  1. Write a change log
  2. Patch Ember-cli to use this system
  3. Remove all mention of API key

This should pave the road for us removing deploy.js, which is hopefully straight forward now.

@ryanto ryanto closed this as completed Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanto