[PW_SID:797481] [v2] shared/shell: Fix --init-script commandline option #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly added option -i/--init-script introduced a short option namespace collision with btmgmt's --index, both of which use '-i'. As a result, a provided --index is treated as a file name: $ sudo btmgmt --index 0 info Unable to open 0: No such file or directory (2) Fix this by using '-s' for --init-script. Fixes: bluez/bluez#639 Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
github-actions
bot
force-pushed
the
workflow
branch
3 times, most recently
from
3a0d959
to
f0acca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added option -i/--init-script introduced a short option
namespace collision with btmgmt's --index, both of which use '-i'.
As a result, a provided --index is treated as a file name:
$ sudo btmgmt --index 0 info
Unable to open 0: No such file or directory (2)
Fix this by using '-s' for --init-script.
Fixes: bluez/bluez#639
Signed-off-by: Juerg Haefliger juerg.haefliger@canonical.com
v2:
src/shared/shell.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)