Add kwarg refreshable_credentials. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is more or less mandatory for long-running service processes inside a Kubernetes cluster that use AWS IAM assume-role authentication (via kiam/kube2iam). AWS limits maximum assume-role session lifetime to 60 minutes. Our web app uses Elasticsearch, and without RefreshableCredentials it would need to handle recreating the aws4auth object before sessions expire. That would not be practical when using elasticsearch_dsl like we do. |
|
this is worth including, can you rebase? |
teemuy
force-pushed
the
add-refreshable-credentials
branch
3 times, most recently
from
dfc65e9
to
7de4ae1
Compare
|
Rebased now @tedder |
|
Any chance of merging this and pushing out a release? We are having the same issue and this would resolve it. Would also resolve #14 |
Closed
A botocore.credentials.RefreshableCredentials instance can now be provided instead of static credentials, enabling automatic credential refresh.
teemuy
force-pushed
the
add-refreshable-credentials
branch
from
7de4ae1
to
e47b748
Compare
|
Rebased to latest master. |
|
Rebased, prepping a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A botocore.credentials.RefreshableCredentials instance can now be provided
instead of static credentials, enabling automatic credential refresh.