Suppression of PHP Warning if Host is not available. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also destructor method for error cleanup. Otherwise PHP would trigger an PHP Notice while in shutdown. For the bug report see this issue: https://bugs.php.net/bug.php?id=65455
1 similar comment
|
+1 |
|
+1 from me too. This is a highly desirable feature. I'm constantly getting warnings about connection problems that are simply to do with brief network connectivity issues etc |
| { | ||
| $this->imapErrors = imap_errors(); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I don't understand the point of this. You're running the "setImapErrors" in the destructor, which is kind of useless- the "this->imapErrors" property is not going to exist after the destructor is called.
There was a problem hiding this comment.
@tedivm The point of the destructor is to clear errors by checking imap_errors() before php goes in shutdown mode. This seems to be a bug in php. Otherwise php would trigger an Unknown on line 0 Notice. See the bug report that I linked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also destructor method for error cleanup. Otherwise PHP would trigger an PHP Notice while in shutdown. For the bug report see this issue: https://bugs.php.net/bug.php?id=65455