Add FT_PEEK in processStructure method #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I justa added FT_PEEK flag for the seen flag is not added automatically when calling the method processStructure while the message was not read
This was referenced Jun 11, 2015
Prestaspirit
changed the title
|
+1 |
tedivm
added a commit
that referenced
this pull request
Jul 9, 2015
Add FT_PEEK in processStructure method
This was referenced Aug 2, 2015
|
What's done is done I guess, but this PR being released in a minor release (0.7.x) really got me surprised as it's a big change from the behaviour of the method in previous releases. And made me wonder: does Fetch follow semver? And can we consider the API stable (thus requiring a major version when making backward incompatible changes)? /cc: @tedivm |
|
@bjornpost you are 100% right and that was a mistake on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just added FT_PEEK flag for the seen flag is not added automatically when calling the method processStructure while the message was not read