Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getPlainTextMessage and getHtmlMessage methods #32

Closed
wants to merge 4 commits into from
Closed

Add getPlainTextMessage and getHtmlMessage methods #32

wants to merge 4 commits into from

Conversation

Arcesilas
Copy link

I needed to create a new mail with the one read. Therefore it's important to me to know if the body i get is plain text or html to set content-type.

@tedivm
Copy link
Member

tedivm commented Jan 20, 2014

This pull requests looks nice, but would you mind adding some test cases in before I merge it?

@Arcesilas
Copy link
Author

I'm not familiar with unit tests, but i'll do it. As soon as i can get vagrant work...

@tedivm
Copy link
Member

tedivm commented Jan 21, 2014

I recently (like, last night) stripped out the Vagrant stuff into it's own repository. There are some helpful instructions in the read me if you need a hand-

https://github.com/tedivm/DovecotTesting

@Arcesilas
Copy link
Author

Hi.

I've finally found some time to make it all work properly (VT-x instructions were not enabled in my BIOS).

I have the testing environment running (had to change path to SetupEnvironment.sh in tests/bootstrap.php since _ _ DIR _ _ refers to tests directory => did you forget to change it ?).

Tests after fresh cloning repository do not pass (only 2 of them are ok). I can't find out a way to know which tests pass or not or the errors that happen (errors, not failures). Verbose option does not change anything to the output. I got this when runnig phpunit first time : https://gist.github.com/OlivierCecillon/a694e8e95b3fd96fa94a
adding --verbose on CLI argument or in phpunit.xml.dist gives the same result

If you have any idea... I keep searching...

@tedivm
Copy link
Member

tedivm commented Feb 15, 2014

Can I see your composer lock file?

@Arcesilas
Copy link
Author

@kevinsmith
Copy link
Contributor

Jumping back on this problem. Since it looks like the forked repo was deleted, I'll just open up a new pull request with my changes. If you're still working on this, @Arcesilas, let me know.

@tedivm
Copy link
Member

tedivm commented Jun 7, 2015

I'm closing this out, as someone submitted another PR that solves the same problem with tests.

@tedivm tedivm closed this Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants