Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destructor to close the imap connection. #62

Closed
wants to merge 1 commit into from
Closed

Added destructor to close the imap connection. #62

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2014

No description provided.

@ghost ghost mentioned this pull request Jun 3, 2014
@tedivm
Copy link
Member

tedivm commented Jun 3, 2014

Did you actually test this? It's very broken.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.81%) when pulling 752a7ea on alexkavon:patch-1 into 8e742ef on tedious:master.

@ghost
Copy link
Author

ghost commented Jun 3, 2014

Sorry, wrong patch. I'll get this fixed up.

@ghost
Copy link
Author

ghost commented Jun 4, 2014

Hmmm... I can't seem to pull a stream to be closed with getImapStream()... what is the proposed method of obtaining the imap_open connection?

@tedivm
Copy link
Member

tedivm commented Jun 4, 2014

getImapStream should work just fine- it's how the rest of the library does it's thing.

@ghost
Copy link
Author

ghost commented Jun 4, 2014

I keep getting the following error on my setup:

imap_close(): 170 is not a valid imap resource

I'm assuming 170 is the returned value of getImapStream()

Here's the code I'm using...

public function __destruct()
 {
        $imapStream = $this->getImapStream();

        imap_close($imapStream);
}

@ghost ghost closed this Jun 13, 2014
@ghost ghost deleted the patch-1 branch June 13, 2014 14:51
@ghost ghost restored the patch-1 branch June 13, 2014 15:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants