FileSystem driver now tries to create cache folder before throwing InvalidArgumentException

[lolautruche]

Hello

Fixes tedious/TedivmStashBundle#15

This is a very small change allowing FileSystem driver to try to create the cache folder if it doesn't already exist. If folder creation fails, then the exception is thrown.

Note the usage of the silent operator (@). It's here only to avoid a verbose warning if folder creation fails since we want to throw an exception.

[Baachi]

Maybe this is better:

if (!is_dir($this->cachepath) && !mkdir($this->cachePath, $this->dirPermissions, true)) {
    throw new InvalidArgumentException(sprintf('Failed to create cache path %s', $this->cachePath));
}

[lolautruche]

You're right 😃 . Fixed

[lolautruche]

Note : Travis is not failing because of this patch, but because of Memached extension installation (probably because of this : http://about.travis-ci.org/blog/2013-03-08-preinstalled-php-extensions/).

[tedivm]

Yup, I actually opened the tickets with Travis about it-

travis-ci/travis-ci#970
travis-ci/travis-ci#971

I've also created a new branch to resolve the testing issues-

https://github.com/tedivm/Stash/tree/travis_test

Once it's resolved I'll merge the travis_test branch back into mainline, and then I'll ask you to just update your PR with those tests so we can see that things are running smoothly.

[lolautruche]

Ok, @tedivm . Just let me know 😃

[andrerom]

@lolautruche Travis should be fixed now, so you can do a git ci --amend & and a force push to get it to test this.

[lolautruche]

@tedivm It seems that your tickets with Travis and Memcached are fixed now, and your travis_test branch looks it passes tests. Could you then merge your travis_test branch into master so I can rebase ?
Thanks !

[tedivm]

The travis_test branch isn't actually passing them all- it's skipping the APC tests. I'm trying to get that resolved (I think I know why it's occurring) and merge that back into mainline. I"ll update here once that's handled.

[lolautruche]

@tedivm Sorry to insist... Actually we really need this in for the next version of eZ Publish and we'll soon enter in a deep code freeze mode. This PR is not related to APC or Memcached since it's only about the FileSystem driver.
If you really want to wait your issue to be fixed, OK but I'll have to point eZ Publish on my fork which I don't really want :-/.

Thanks.