Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/set mode #227

Closed
wants to merge 21 commits into from
Closed

Feature/set mode #227

wants to merge 21 commits into from

Conversation

alexbowers
Copy link
Contributor

No description provided.

@alexbowers
Made changes for the setItemClass to use the ItemInterface
03b9a58
@alexbowers
Merge branch 'refactor/set-item-class-injection'
5c89221
@alexbowers
Added the mode constants
323f020
@alexbowers
Define the pool mode methods in the interface
0c08ae7
@alexbowers
Mode default and getter setter implemented
ed96072
@alexbowers
Set mode return boolean
2d70882
@alexbowers
Allow mode to be set in the constructor
4d96917
@alexbowers
Improved docblocks
d36219e
@alexbowers
Fix typehinting
ea19648 
Turns out you cant typehint constants. My bad.
@alexbowers
Remove unused code
779cd78
@alexbowers
The pools mode in the item
a856e6c
@alexbowers
Setting the mode of the pool for the item
ed6f8db
@alexbowers
Implement force miss
63a7173
@alexbowers
Implement readonly
9ab552b
@alexbowers
implement write only
3cc0bc7
@alexbowers
Implement disabled
0080aaa
@alexbowers
Code format fixes
e401cc2
@alexbowers
Implement missing methods in tests
f651a23
@alexbowers
READ ONLY should not clear
fde4333
@alexbowers
Test added for pool getter setters
98c1eca
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.15%) to 91.67% when pulling 98c1eca on alexbowers:feature/set-mode into 46c83b6 on tedious:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.15%) to 91.67% when pulling 98c1eca on alexbowers:feature/set-mode into 46c83b6 on tedious:master.

@alexbowers
Copy link
Contributor Author

@tedivm I will need some help testing the actual modes, since I couldn't figure out how to do it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.27%) to 91.55% when pulling 98aaa45 on alexbowers:feature/set-mode into 46c83b6 on tedious:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.27%) to 91.55% when pulling 98aaa45 on alexbowers:feature/set-mode into 46c83b6 on tedious:master.

@alexbowers
Copy link
Contributor Author

@tedivm any input please?

@piwi91
Copy link

piwi91 commented Feb 23, 2016

LGTM 👍

@alexbowers
Copy link
Contributor Author

@tedivm Feedback please?

@alexbowers alexbowers closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexbowers @coveralls @piwi91