Major Refactoring #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CacheService now uses itself as a proper Pool class. It creates CacheItem objects that extends the Stash\Item classes directly, but also give optional data collection support. This CacheItem class replaces the CacheResultObject.
Changing Logger to Tracker makes it clear what this function does compared to the actual monolog-style tracking. Handler to Driver is meant to maintain consistency with Stash and it’s terminology.
Changed “logRequest” to “trackRequest”, and removed the namespace trimming from the key as it’s no longer needed. Plus tests!
The getDrivers tweak simply uses the label instead of the class name when returning the names of available drivers.
‘cause I fail at remembering to do this . . .
People who use the Doctrine Adaptor should have Doctrine in their own composer file, and we shouldn’t make doctrine a dependency for projects that don’t need it. This is a step in that direction that also allows us to still test the Doctrine Adaptor.
These are based off the Doctrine test suite itself.
Travis-CI is choking on the include due to some weird composer/phpunit/bootstrap nonsense.
getStats returns an array even when a Tracker isn’t present, maintaining compatibility. Cleaned up lots of dead code and refactored a little bit. Improved test coverage.
Now if Doctrine isn’t installed the test suite skips the DoctrineAdaptor test instead of erroring out.
Then made more tests :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[
](https://coveralls.io/r/tedivm/TedivmStashBundle?branch= refactor)
This is a major refactoring meant to improve test coverage, increase efficiency, and ease the general use of this bundle.