Skip to content

Commit

Permalink
fix: msnodesqlv8 connection string uses correct instance name
Browse files Browse the repository at this point in the history
driver was not using the correct option for instanceName and so it was
undefined rather than the correct value.
  • Loading branch information
partik-mis authored and dhensby committed Sep 5, 2023
1 parent 0c9ce86 commit eb3e4d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/msnodesqlv8/connection-pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ConnectionPool extends BaseConnectionPool {
if (!this.config.connectionString) {
cfg.conn_str = buildConnectionString({
Driver: CONNECTION_DRIVER,
Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.instanceName}` : `${this.config.server},${this.config.port}`,
Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.options.instanceName}` : `${this.config.server},${this.config.port}`,
Database: this.config.database,
Uid: this.config.user,
Pwd: this.config.password,
Expand Down

0 comments on commit eb3e4d0

Please sign in to comment.