Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with tedious #604

Closed
dang-1234 opened this issue Jan 31, 2018 · 22 comments
Closed

Issues with tedious #604

dang-1234 opened this issue Jan 31, 2018 · 22 comments

Comments

@dang-1234
Copy link

dang-1234 commented Jan 31, 2018

I just installed mssql in to my new environment and I see these errors:
It works without errors in my old environment.

Any ideas?

Thanks!

### tedious deprecated The IntN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:63:20
tedious deprecated The BitN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:71:40
tedious deprecated The FloatN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:73:20
tedious deprecated The MoneyN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:78:20
tedious deprecated The NumericN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:82:44
tedious deprecated The DecimalN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:83:44
tedious deprecated The DateTimeN data type is internal and will be removed. node_modules\mssql\lib\tedious.js:85:20
tedious deprecated The TimeN data type alias is deprecated, please use Time instead. node_modules\mssql\lib\tedious.js:88:20
tedious deprecated The DateN data type alias is deprecated, please use Date instead. node_modules\mssql\lib\tedious.js:89:20
tedious deprecated The DateTime2N data type alias is deprecated, please use DateTime2 instead. node_modules\mssql\lib\tedious.js:90:20
tedious deprecated The DateTimeOffsetN data type alias is deprecated, please use DateTimeOffset instead. node_modules\mssql\lib\tedious.js:91:20

@dang-1234 dang-1234 changed the title Issues ith tedious Issues with tedious Jan 31, 2018
@cepm-nate
Copy link

I'm seeing this as well. Brand new install of node-mssql.

@CrescentCraftorium
Copy link

CrescentCraftorium commented Feb 6, 2018

+1 - Version 4.1.0

Edit:

Rolling tedious back to Version 2.2.4 gets rid of these messages. May be an issue with that package.

@serkandurusoy
Copy link

Yup, and I'm getting

tedious deprecated The `IntN` data type is internal and will be removed. at ../../../../../node_modules/mssql-updated/lib/tedious.js:63:20

coming in from https://github.com/patriksimek/node-mssql/blob/master/lib/tedious.js#L63

@deepakbajaj
Copy link

Can you suggest how to roll back tedious to suggested version to solve the issue.

@CrescentCraftorium
Copy link

CrescentCraftorium commented Feb 8, 2018

Either install that specific version with
npm install --save tedious@2.2.4
or edit your package.json to reflect that version and run npm update

"dependencies": {
  "mssql": "^4.1.0",
  "tedious": "2.2.4"
}

I did this as a troubleshooting step though. I don't know if mssql requires the latest version of tedious to operate properly or not, so this may break other features

@serkandurusoy
Copy link

@WebGaze nice workaroung, though I'd prefer moving forward instead of backward ;)

@deepakbajaj
Copy link

Thanks for quick reply :)

@magnusjt
Copy link

Why keep inaccurate dependencies in the first place? ("tedious": "^2.0.0"). I know it's supposed to be backwards compatible, but that's often just in theory.

davepreston added a commit to davepreston/node-mssql that referenced this issue Feb 21, 2018
@reksc
Copy link

reksc commented Mar 9, 2018

Hi, is there a plan to include aca00f0 into a stable release? I have plenty of messages in my log due to this while using TypeORM.

mottykohn added a commit to mottykohn/node-mssql that referenced this issue Mar 16, 2018
Switched all the deprecated type to the recommended ones
@mottykohn
Copy link

Just realized @davepreston also created a fix, but not sure how that PR fixes the problem it only changes the switch from tds to sql. I think both have to be pulled to fully fix the problem.

justinwoo added a commit to justinwoo/node-mssql that referenced this issue Apr 3, 2018
@saostad
Copy link

saostad commented Apr 4, 2018

What's the solution?
Any Help please?

@mottykohn
Copy link

@saostad for now you can do the following:
npm install https://github.com/justinwoo/node-mssql.git#fixes
Please note that this is not the official way of doing things but it should work. Maybe https://github.com/justinwoo can help you he is reachable on tweeter as posted on link.

@jonstuebe
Copy link
Contributor

@mottykohn that is missing a couple of things. I added the rest of the deprecations in a new pr: #643

@jxjj
Copy link

jxjj commented Apr 30, 2018

If anyone lands here just wanting to silence the deprecation warnings, you can add an environment variable NO_DEPRECATION=tedious, as pointed out in tediousjs/tedious/pull/691.

For example, inpackage.json with ava as a testrunner:

"scripts": {
   "test": "NO_DEPRECATION=tedious ava"
}

@luker2
Copy link

luker2 commented May 3, 2018

Referencing @jonstuebe commit in package.json as described here works for me temporarily.

  "dependencies": {
    "mssql": "git+https://github.com/tediousjs/node-mssql.git#c9209d8b44141561de4fdf20bc43e30c140b5da7",
  }

UPDATE: I actually began receiving error fatal: reference is not a tree during npm install. Didn't dig into it too much, I'm back to defining "tedious": "2.2.4" in package.json

@frostbytedata
Copy link

So as a dev is it safe for me to suppress these errors for now until an update comes from Knex or Tedious (both)? I feel dirty just sweeping them under the rug.

@shawnmgoulet
Copy link

+1 for v4.1.0 - @WebGaze workaround throwing it back to v2.2.4 still works, looks like this PR submitted April 14th addresses it, but still hasn't been merged????? 🤔🤔

@patriksimek
Copy link
Collaborator

Fixed in #643. Sorry for the delay.

@ves-krd
Copy link

ves-krd commented Jul 7, 2018

Still not fixed for me...

@patriksimek
Copy link
Collaborator

@ves-krd What version of node-mssql do you use?

@MyPublicGitHubAcct
Copy link

I am seeing something very similar today -

tedious deprecated The `IntN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:63:20
tedious deprecated The `BitN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:71:40
tedious deprecated The `FloatN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:73:20
tedious deprecated The `MoneyN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:78:20
tedious deprecated The `NumericN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:82:44
tedious deprecated The `DecimalN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:83:44
tedious deprecated The `DateTimeN` data type is internal and will be removed. node_modules/mssql/lib/tedious.js:85:20
tedious deprecated The `TimeN` data type alias is deprecated, please use `Time` instead. node_modules/mssql/lib/tedious.js:88:20
tedious deprecated The `DateN` data type alias is deprecated, please use `Date` instead. node_modules/mssql/lib/tedious.js:89:20
tedious deprecated The `DateTime2N` data type alias is deprecated, please use `DateTime2` instead. node_modules/mssql/lib/tedious.js:90:20
tedious deprecated The `DateTimeOffsetN` data type alias is deprecated, please use `DateTimeOffset` instead. node_modules/mssql/lib/tedious.js:91:20
tedious deprecated The `UniqueIdentifierN` data type alias is deprecated, please use `UniqueIdentifier` instead. node_modules/mssql/lib/tedious.js:93:20

with the following dependencies...

"dependencies": {
    "express": "^4.16.3",
    "mssql": "^4.1.0",
    "tedious": "^2.6.4"
  },

@mottykohn
Copy link

@MyPublicGitHubAcct You need version 4.2.0 via npm i mssql@next for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests