Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Isolation Level for all Transactions #1005

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Conversation

marvinscharle
Copy link
Contributor

What this does:

  • Adds static attribute defaultIsolationLevel to Transaction (which defaults to the current value ISOLATION_LEVEL.READ_COMMITTED)
  • If a user wants to change the isolation level globally for an app, they have to update Transaction.defaultIsolationLevel to the desired isolation level.

Example:

Transaction.defaultIsolationLevel = ISOLATION_LEVEL.READ_UNCOMMITTED

// All transactions will now have the isolation level READ_UNCOMMITTED unless explicitly specified on each transaction

@dhensby dhensby changed the base branch from master to 6 March 13, 2020 18:26
Copy link
Collaborator

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good and really appreciate the tests

@dhensby dhensby merged commit e88ab9a into tediousjs:6 Mar 13, 2020
@dhensby
Copy link
Collaborator

dhensby commented Mar 13, 2020

This has been released as v6.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants