New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't forward errors up the pipe chain when in stream mode #1028

Merged

willmorgan merged 2 commits into tediousjs:master from dhensby:pulls/no-forwareded-errors-during-pipe

Apr 22, 2020

Collaborator

dhensby commented Apr 20, 2020

What this does:

Piped streams shouldn't have errors passed up the pipe chain, this stops errors on the request stream being sent to the piped stream


          Dont forward errors up the pipe chain when in stream mode

f5f41fa

Collaborator Author

dhensby commented Apr 20, 2020

see #997

dhensby requested a review from willmorgan

April 20, 2020 12:00


          Update changelogs

28aa5c4

dhensby force-pushed the pulls/no-forwareded-errors-during-pipe branch from 696b1d4 to 28aa5c4 Compare

April 20, 2020 12:05

willmorgan approved these changes

View reviewed changes

willmorgan merged commit 7245768 into tediousjs:master

dhensby deleted the pulls/no-forwareded-errors-during-pipe branch

April 25, 2020 16:33

dhensby mentioned this pull request

uncaughtException in Stream Mode #1324

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment