FIX Protect against object prototype pollution

[dhensby]

What this does:

Fixes #261

[willmorgan]

Builtin prototype extension is a bad idea so while we should guard against security related implications, this does look ugly.

I wonder if we should put this check in a function rather than peppering it everywhere?

[dhensby]

I wonder if we should put this check in a function rather than peppering it everywhere?

We'd replace one function with another 1 line function, which would have to be peppered about, so I'm not clear on the advantage of doing that

this does look ugly.

The alternative is to change how we iterate through the properties of an object, just Object.keys() maybe? But I don't really see that being too much nicer - we're still mitigating bad code, but that's kid of our job as a library.

[willmorgan]

We'd replace one function with another 1 line function, which would have to be peppered about, so I'm not clear on the advantage of doing that

I think a function named safeIterateParameters would be a bit more descriptive for future travellers.

[dhensby]

I think a function named safeIterateParameters would be a bit more descriptive for future travellers.

I'm not sure that's going to be any clearer - that means a future dev will have to go and look at what the function does (not a lot) rather than just see a single inline call to hasOwnProperty

It's also oddly specific, what if we want to 'safely iterate' over another object?

[willmorgan]

Shrug.