FIX Repeat calls to mssql.connect() will only resolve when the pool is connected #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement on #804
Since the previous PR repeated calls to
mssql.connect()
would resolve instantly even if the pool wasn't yet in a connected state. eg:This has lead to many issues where developers are not taking into account that they shouldn't be relying on being able to call
connect()
repeatedly.This will improve developer experience as they will need to think less about managing the state of their global connection
todo: