Remove the need for specifying a length for an output parameter of ty…

…pe varchar or nvarchar.
tediousjs · Apr 1, 2012 · 5765a3d · 5765a3d
1 parent 13f5508
commit 5765a3d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/data-type.coffee b/lib/data-type.coffee
@@ -140,12 +140,13 @@ TYPE =
     name: 'VarChar'
     hasCollation: true
     dataLengthLength: 2
+    maximumLength: 8000
     writeParameterData: (buffer, parameter) ->
       if parameter.length
         length = parameter.length
       else if parameter.value
         length = parameter.value.length
-      else length = 1         # Can't declare length less than 1 character.
+      else length = @.maximumLength
 
       # ParamMetaData (TYPE_INFO)
       buffer.writeUInt8(@.id)
@@ -172,12 +173,13 @@ TYPE =
     name: 'NVarChar'
     hasCollation: true
     dataLengthLength: 2
+    maximumLength: 4000
     writeParameterData: (buffer, parameter) ->
       if parameter.length
         length = 2 * parameter.length
       else if parameter.value
         length = 2 * parameter.value.length
-      else length = 2             # Can't declare length less than 1 character.
+      else length = @maximumLength
 
       # ParamMetaData (TYPE_INFO)
       buffer.writeUInt8(@.id)

diff --git a/test/integration/rpc-test.coffee b/test/integration/rpc-test.coffee
@@ -250,9 +250,7 @@ testProcOutput = (test, type, typeAsString, value) ->
   )
 
   request.addParameter(type, 'paramIn', value)
-  request.addOutputParameter(type, 'paramOut',
-    length: 10
-  )
+  request.addOutputParameter(type, 'paramOut')
 
   request.on('doneProc', (rowCount, more, returnStatus) ->
     test.ok(!more)