test: date range check

tediousjs · Feb 7, 2024 · ecc7fb3 · ecc7fb3
1 parent e30d927
commit ecc7fb3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/data-types/date.ts b/src/data-types/date.ts
@@ -7,9 +7,6 @@ const EPOCH_DATE = LocalDate.ofYearDay(1, 1);
 const NULL_LENGTH = Buffer.from([0x00]);
 const DATA_LENGTH = Buffer.from([0x03]);
 
-const MIN_DATE = new globalDate('January 1, 0001');
-const MAX_DATE = new globalDate('December 31, 9999');
-
 const Date: DataType = {
   id: 0x28,
   type: 'DATEN',
@@ -65,11 +62,14 @@ const Date: DataType = {
 
     // TODO: check date range: January 1, 0001, through December 31, 9999
     //    : time range: 00:00:00 through 23:59:59.997
+    let year;
     if (options && options.useUTC) {
-      value = new globalDate(value.toUTCString());
+      year = value.getUTCFullYear();
+    } else {
+      year = value.getFullYear();
     }
 
-    if (value < MIN_DATE || value > MAX_DATE) {
+    if (year < 1 || year > 9999) {
       throw new TypeError('Out of range.');
     }
 

diff --git a/test/unit/data-type.js b/test/unit/data-type.js
@@ -215,7 +215,9 @@ describe('Date', function() {
   describe('.validate', function() {
     it('returns a TypeError for dates that are out of range', function() {
       assert.throws(() => {
-        TYPES.Date.validate(new Date('Dec 31 2000'));
+        const testDate = new Date();
+        testDate.setFullYear(0);
+        TYPES.Date.validate(testDate);
       }, TypeError, 'Out of range.');
 
       assert.throws(() => {
@@ -742,7 +744,7 @@ describe('Money', function() {
     });
   });
 
-  describe.only('.validate', function() {
+  describe('.validate', function() {
     it('throws Invalid number error for NaN input', function() {
       assert.throws(() => {
         TYPES.TinyInt.validate('string');