Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TVP parameters in Connection.execSql #1327

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

arthurschreiber
Copy link
Collaborator

This takes the changes from @mastodon0 over at #1180 and updates them to match recent updates to tedious.

Switching to use stored procedure ids instead of stored procedure names comes with the advantage that TVP parameters can be used with Connection.execSql.

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #1327 (2b5d5a0) into master (ed02374) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   79.75%   79.86%   +0.10%     
==========================================
  Files          91       92       +1     
  Lines        4659     4663       +4     
  Branches      856      857       +1     
==========================================
+ Hits         3716     3724       +8     
+ Misses        676      672       -4     
  Partials      267      267              
Impacted Files Coverage Δ
src/connection.ts 61.94% <100.00%> (ø)
src/rpcrequest-payload.ts 96.22% <100.00%> (+6.03%) ⬆️

... and 3 files with indirect coverage changes

@arthurschreiber arthurschreiber merged commit a37199b into master Jun 28, 2023
23 of 26 checks passed
@arthurschreiber arthurschreiber deleted the arthur/use-stored-procedure-ids branch June 28, 2023 19:24
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

🎉 This PR is included in version 16.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants