Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TVP test not working on Azure SQL #1556

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

arthurschreiber
Copy link
Collaborator

Before submitting a PR :

  1. Ensure your fork is created from master branch of the repository.
  2. Run npm install in the root folder.
  3. After bug fix/code change, ensure all the existing tests and new tests (if any) pass (npm run-script test-all). During development, to run individual test use node_modules/nodeunit test/<test_file.js> -t <test_name>.
  4. Build the driver (npm run build).
  5. Run eslint and flow typechecker (npm run lint).
  6. Run commitlint (node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.

Thank you for Contributing!

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #1556 (39aa3f6) into master (299d576) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   79.88%   80.78%   +0.90%     
==========================================
  Files          92       92              
  Lines        4663     4663              
  Branches      857      857              
==========================================
+ Hits         3725     3767      +42     
+ Misses        671      621      -50     
- Partials      267      275       +8     

see 4 files with indirect coverage changes

@MichaelSun90 MichaelSun90 merged commit 07cac40 into master Jul 19, 2023
26 checks passed
@MichaelSun90 MichaelSun90 deleted the arthur/fix-tests-on-azure branch July 19, 2023 20:06
@github-actions
Copy link

🎉 This PR is included in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants