feat: IDE Integration #1630
feat: IDE Integration #1630
Conversation
Better integrate VS Code and into the project. Update `.gitignore` to encompass more generated content and better Sublime Text generated content. Update Dev Container configs and base images. Integrate VS Code debugging support. Randomize SA password.
These should not be present any more since the config is now a workspace config instead of a folder config.
There was a problem hiding this comment.
Thank you for the PR. I just added few question based on my limited knowledge on IDE setup. It will still be better to get some feed back from @arthurschreiber to finalize the changes within the PR.
| "files.trimTrailingWhitespace": true, | ||
| "files.insertFinalNewline": true, | ||
| "files.trimFinalNewlines": true | ||
| } |
There was a problem hiding this comment.
I saw these configuration are moved into Tedious.code-workspace. Is settings.json becoming a outdated way to handle this or it is just simpler to do this within the Tedious.code-workspace?
There was a problem hiding this comment.
settings.json is fully supported and not going away to the best of my knowledge.
I believe it is simpler as you can centralize more configurations in the workspace config. It technically gives you more capabilities as settings.json relates only to a single set of configurations for the folder, the configuration of the workspace allows for more options and integrations and I believe it also has codespace support.
Some examples are folder exclusions on the workspace to hide stuff that is not necessary, this is not supported on settings.json
There was a problem hiding this comment.
You can also include extension recommendations in the same file.
It is also better for monolithic projects.
| @@ -21,7 +21,7 @@ services: | |||
|
|
|||
| environment: | |||
| - "ACCEPT_EULA=Y" | |||
| - "SA_PASSWORD=yourStrong(!)Password" | |||
| - "MSSQL_SA_PASSWORD=QhNemHjCWHui9vNnRC.TMRAhusvM3n9_" | |||
There was a problem hiding this comment.
May I ask is this password here generated in someway during the run time?
There was a problem hiding this comment.
It is not generated, I just regenerated the password to reduce reliance on hardcoded non-random passwords.
It doesn't change any behavior.
I did update the environmental variable name as the one that was used is no longer supported.
Changes:
settings.jsonfile).gitignorefrom GitHub forSublime TextandNode.JS.