fix: error should not expose all port numbers and instance names of SQL Server #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using incorrect instanceName in config throws an error that lists all the instance names (in that SQL Server), along with their port number and few other details.
Suraiya-Hameed
changed the title
Suraiya-Hameed
force-pushed
the
Incorrect_InstanceName
branch
from
3744f59
to
84e9d3f
Compare
arthurschreiber
approved these changes
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using incorrect/non-existent instanceName in config throws an error that lists all the instance names (in that SQL Server), along with their port number and few other details. This PR alters the error to contain just the Server name.
Current message looks like: