Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: just a quick typo fix #882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tightightight
Copy link

Before submitting a PR :

  1. Ensure your fork is created from master branch of the repository.
  2. Run npm install in the root folder.
  3. After bug fix/code change, ensure all the existing tests and new tests (if any) pass (npm run-script test-all). During development, to run individual test use node_modules/nodeunit test/<test_file.js> -t <test_name>.
  4. Build the driver (npm run build).
  5. Run eslint and flow typechecker (npm run lint).
  6. Run commitlint (node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.

Thank you for Contributing!

@tightightight
Copy link
Author

Just fixed the spelling of License in the readme <3

IanChokS added a commit to IanChokS/tedious that referenced this pull request Aug 12, 2019
@IanChokS IanChokS mentioned this pull request Aug 12, 2019
@IanChokS IanChokS changed the title just a quick typo fix chore: just a quick typo fix Aug 12, 2019
@MichaelSun90
Copy link
Contributor

Hi @arthurschreiber, I thought License is spelling differently in British and American English, and both of them are correct. Do we have a constrain for which spelling should be used or either one is OK? If either one is ok, then I think it is safe to close this PR fro now?

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #882 (0978d13) into master (ed02374) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   79.75%   79.69%   -0.07%     
==========================================
  Files          91       91              
  Lines        4659     4659              
  Branches      856      856              
==========================================
- Hits         3716     3713       -3     
- Misses        676      678       +2     
- Partials      267      268       +1     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants