-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: just a quick typo fix #882
base: master
Are you sure you want to change the base?
Conversation
Just fixed the spelling of License in the readme <3 |
Hi @arthurschreiber, I thought License is spelling differently in British and American English, and both of them are correct. Do we have a constrain for which spelling should be used or either one is OK? If either one is ok, then I think it is safe to close this PR fro now? |
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
- Coverage 79.75% 79.69% -0.07%
==========================================
Files 91 91
Lines 4659 4659
Branches 856 856
==========================================
- Hits 3716 3713 -3
- Misses 676 678 +2
- Partials 267 268 +1 |
Before submitting a PR :
master
branch of the repository.npm install
in the root folder.npm run-script test-all
). During development, to run individual test usenode_modules/nodeunit test/<test_file.js> -t <test_name>
.npm run build
).npm run lint
).node_modules/.bin/commitlint --from origin/master --to HEAD
). Refer commit conventions and commit rules.Thank you for Contributing!