Emit connect event with error (if connecting) or emit errorMessage event... #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent on socket error When a network issue prevents connection to the database, there is no callback made to the connection callback nor to the errorMessage callback. Only the connection.end event is fired. This leads to silent failures.
|
I had a situation in which connections to a database could not be made intermittently due to network configuration issues. When connections were not established, my expectation was that the connection.on('connect', callback) would be called with error information. This was never called. This lead to situations in which I was unable to determine easily that their had been a failure and to take appropriate action in those cases. This pull request addresses the situation that I had encountered. |
pekim
added a commit
that referenced
this pull request
Apr 28, 2013
Emit connect event with error (if connecting) or emit errorMessage event...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on socket error
When a network issue prevents connection to the database, there is no
callback made to the connection callback nor to the errorMessage
callback. Only the connection.end event is fired. This leads to silent
failures.