Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+c from within an active ssm connection kills the ecsgo session #29

Closed
userhas404d opened this issue Jan 19, 2023 · 3 comments
Closed

Comments

@userhas404d
Copy link

First off, thank you for this tool!

Seeing this behavior on the latest version, details are pretty straightforward and easily reproducible but happy to provide more on request.

@userhas404d userhas404d changed the title ctrl+c from within an active ssm connection kills the session ctrl+c from within an active ssm connection kills the ecsgo session Jan 19, 2023
@tedsmitt
Copy link
Owner

Hey @userhas404d I've fixed this in https://github.com/tedsmitt/ecsgo/releases/tag/v0.4.5-beta.2 - can you check it out and feedback?

@userhas404d
Copy link
Author

finally had a chance to test this today and was able to confirm it works. Thank you!

If you want a separate issue for this I can create one (not a huge deal from my perspective) but I did notice that the beta release does not provide version information:

❯ ecsgo-beta --version
ecsgo version Version: unset, Commit: unset, Built date: unset, Built by: unset

@tedsmitt
Copy link
Owner

Hey @userhas404d thank you so much for taking the time to test! Much appreciated.

Also great spot! I raised #35 and have pushed a fix, so this will be resolved when I create the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants